PHILO-HE commented on code in PR #7168:
URL: https://github.com/apache/incubator-gluten/pull/7168#discussion_r1751163802
##########
gluten-substrait/src/main/scala/org/apache/gluten/expression/WindowFunctionsBuilder.scala:
##########
@@ -31,7 +31,7 @@ object WindowFunctionsBuilder {
val substraitFunc = windowFunc match {
// Handle lag with negative inputOffset, e.g., converts lag(c1, -1) to
lead(c1, 1).
// Spark uses `-inputOffset` as `offset` for Lag function.
- case lag: Lag if lag.offset.eval(EmptyRow).asInstanceOf[Int] > 0 =>
Review Comment:
@kecookier, I see. Thanks for your clarification! Seems there is no way to
let gluten adapt to the two implementations. Should you fix it in a forked
gluten on your side?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
