This is an automated email from the ASF dual-hosted git repository.
philo pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git
The following commit(s) were added to refs/heads/main by this push:
new 7861829db [GLUTEN-7208][VL] Fix loading libvelox.so failed when using
static glog (#7209)
7861829db is described below
commit 7861829dbd0147a86aa1d5914d2a41c70f66f3b2
Author: Helin Jin <[email protected]>
AuthorDate: Fri Sep 13 13:20:28 2024 +0800
[GLUTEN-7208][VL] Fix loading libvelox.so failed when using static glog
(#7209)
---
cpp/core/CMakeLists.txt | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/cpp/core/CMakeLists.txt b/cpp/core/CMakeLists.txt
index 4c84d15f3..270468275 100644
--- a/cpp/core/CMakeLists.txt
+++ b/cpp/core/CMakeLists.txt
@@ -213,13 +213,11 @@ file(MAKE_DIRECTORY ${root_directory}/releases)
add_library(gluten SHARED ${SPARK_COLUMNAR_PLUGIN_SRCS})
add_dependencies(gluten jni_proto)
-if(ENABLE_GLUTEN_VCPKG)
- # Hide symbols of some static dependencies. Otherwise, if such dependencies
- # are already statically linked to libvelox.so, a runtime error will be
- # reported: xxx is being linked both statically and dynamically.
- target_link_options(
- gluten PRIVATE
-Wl,--version-script=${CMAKE_CURRENT_SOURCE_DIR}/symbols.map)
-endif()
+# Hide symbols of some static dependencies. Otherwise, if such dependencies are
+# already statically linked to libvelox.so, a runtime error will be reported:
+# xxx is being linked both statically and dynamically.
+target_link_options(
+ gluten PRIVATE -Wl,--version-script=${CMAKE_CURRENT_SOURCE_DIR}/symbols.map)
if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS 9.0)
execute_process(
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
