jinchengchenghh commented on code in PR #7229:
URL: https://github.com/apache/incubator-gluten/pull/7229#discussion_r1758411766
##########
gluten-substrait/src/main/scala/org/apache/gluten/planner/cost/RoughCostModel.scala:
##########
@@ -34,6 +36,10 @@ class RoughCostModel extends LongCostModel {
// Make trivial ProjectExec has the same cost as ProjectExecTransform
to reduce unnecessary
// c2r and r2c.
10L
+ case r2c: RowToColumnarExecBase if hasComplexTypes(r2c.schema) =>
+ // Avoid moving computation back to native when transition has complex
types in schema.
+ // Such transitions are observed to be extreme expensive as of now.
+ Long.MaxValue
Review Comment:
Can we add a more reasonable value to the cost? How can we measure the
operator cost now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
