PHILO-HE commented on code in PR #7235:
URL: https://github.com/apache/incubator-gluten/pull/7235#discussion_r1759639256
##########
gluten-ut/spark33/src/test/scala/org/apache/spark/sql/catalyst/expressions/GlutenMathExpressionsSuite.scala:
##########
@@ -18,11 +18,40 @@ package org.apache.spark.sql.catalyst.expressions
import org.apache.gluten.utils.BackendTestUtils
+import org.apache.spark.sql.GlutenQueryTestUtil.isNaNOrInf
import org.apache.spark.sql.GlutenTestsTrait
import org.apache.spark.sql.catalyst.dsl.expressions._
import org.apache.spark.sql.types._
+import org.apache.commons.math3.util.Precision
+
+import java.nio.charset.StandardCharsets
+
class GlutenMathExpressionsSuite extends MathExpressionsSuite with
GlutenTestsTrait {
+ override protected def checkResult(
Review Comment:
Hi @taiyang-li, is this check also applied to Velox backend testing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
