PHILO-HE commented on code in PR #7248:
URL: https://github.com/apache/incubator-gluten/pull/7248#discussion_r1759703659
##########
gluten-ut/spark34/src/test/scala/org/apache/spark/sql/sources/GlutenInsertSuite.scala:
##########
@@ -623,6 +624,24 @@ class GlutenInsertSuite
}
}
}
+
+ testGluten("GLUTEN-7213: Check fallback reason with
CheckOverflowInTableInsert") {
Review Comment:
Can we put the test into a common place? E.g.,
https://github.com/apache/incubator-gluten/tree/a7c9567bc7acdd14c8474c3d2dc99d1cfd062b56/gluten-ut/test/src/test/scala/org/apache/gluten/expressions
You can use `testWithSpecifiedSparkVersion` to let it be tested with
spark-3.5.
##########
gluten-substrait/src/main/scala/org/apache/gluten/expression/ExpressionConverter.scala:
##########
@@ -481,6 +481,10 @@ object ExpressionConverter extends SQLConfHelper with
Logging {
substraitExprName,
replaceWithExpressionTransformer0(c.child, attributeSeq,
expressionsMap),
c)
+ case c if c.getClass.getSimpleName.equals("CheckOverflowInTableInsert")
=>
+ throw new UnsupportedOperationException(
Review Comment:
-> GlutenNotSupportException
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
