zhztheplayer commented on code in PR #7234: URL: https://github.com/apache/incubator-gluten/pull/7234#discussion_r1767988612
########## gluten-core/src/main/java/org/apache/gluten/jni/JniUtils.java: ########## @@ -14,7 +14,7 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -package org.apache.gluten.init; +package org.apache.gluten.jni; Review Comment: If we move it to `gluten-core`, could we do some minor refactors on this class at the same time? My suggestion would be: 1. `org.apache.gluten.jni.JniUtils` -> `org.apache.gluten.utils.ConfigUtil` 1. `JniUtils.toNativeConf` -> `ConfigUtil.serialize` or `ConfigUtil.serializeMap` Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
