Yohahaha commented on code in PR #7300:
URL: https://github.com/apache/incubator-gluten/pull/7300#discussion_r1770722024
##########
cpp/velox/compute/WholeStageResultIterator.cc:
##########
@@ -238,17 +238,21 @@ int64_t WholeStageResultIterator::spillFixedSize(int64_t
size) {
// As of now, non-zero running threads usually happens when:
// 1. Task A spills task B;
// 2. Task A trys to grow buffers created by task B, during which spill
is requested on task A again;
- VLOG(2) << logPrefix << "Spill is requested on a task " <<
task_->taskId()
- << " that has non-zero running threads, which is not currently
supported. Skipping.";
+ LOG(WARNING) << logPrefix << "Spill is requested on a task " <<
task_->taskId()
+ << " that has non-zero running threads, which is not
currently supported. Skipping.";
return shrunken;
}
int64_t remaining = size - shrunken;
- LOG(INFO) << logPrefix << "Trying to request spill for " << remaining << "
bytes...";
- auto* mm = memoryManager_->getMemoryManager();
+ LOG(INFO) << logPrefix << "Trying to request spill for " <<
velox::succinctBytes(remaining);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
