majetideepak commented on code in PR #7308:
URL: https://github.com/apache/incubator-gluten/pull/7308#discussion_r1773146665
##########
ep/build-velox/src/get_velox.sh:
##########
@@ -107,7 +107,7 @@ function process_setup_centos9 {
sed -i '/^.*dnf_install autoconf/a\ dnf_install libxml2-devel
libgsasl-devel libuuid-devel' scripts/setup-centos9.sh
ensure_pattern_matched 'install_gflags' scripts/setup-centos9.sh
- sed -i '/^function install_gflags.*/i function install_openssl {\n
wget_and_untar
https://github.com/openssl/openssl/archive/refs/tags/OpenSSL_1_1_1s.tar.gz
openssl \n cd openssl \n ./config no-shared && make depend && make && sudo
make install \n cd ..\n}\n' scripts/setup-centos9.sh
+ sed -i '/^function install_gflags.*/i function install_openssl {\n
wget_and_untar
https://github.com/openssl/openssl/releases/download/openssl-3.2.2/openssl-3.2.2.tar.gz
openssl \n cd openssl \n ./config no-shared && make depend && make && sudo
make install \n cd ..\n}\n' scripts/setup-centos9.sh
Review Comment:
@pratham76 `scripts/setup-centos9.sh` is coming from Velox.
In Velox, there was a recent change
https://github.com/facebookincubator/velox/pull/10920 to use
`${DEPENDENCY_DIR}` for dependencies. As @zhouyuan suggested, we need to use
`cd ${DEPENDENCY_DIR}/openssl` when `wget_and_untar` is used.
Can you validate your change on the latest gluten main branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
