zhztheplayer commented on code in PR #7360:
URL: https://github.com/apache/incubator-gluten/pull/7360#discussion_r1778176384
##########
gluten-substrait/src/main/scala/org/apache/gluten/extension/columnar/validator/Validators.scala:
##########
@@ -116,7 +116,7 @@ object Validators {
}
}
- private class FallbackComplexExpressions(threshold: Int) extends Validator {
+ class FallbackComplexExpressions(threshold: Int) extends Validator {
Review Comment:
Instead of making this public, could just move the shared code into
`ExpressionUtils`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
