zml1206 commented on code in PR #7363: URL: https://github.com/apache/incubator-gluten/pull/7363#discussion_r1793057735
########## cpp/velox/substrait/SubstraitToVeloxPlan.cc: ########## @@ -1669,7 +1669,8 @@ bool SubstraitToVeloxPlanConverter::canPushdownOr( } Review Comment: `setInRange` itself retains a parameter `forOrRelation`, which is used for verification. We only need to judge the first singularOrList in or. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
