yma11 commented on code in PR #7111:
URL: https://github.com/apache/incubator-gluten/pull/7111#discussion_r1797511833


##########
gluten-substrait/src/main/scala/org/apache/gluten/execution/BasicPhysicalOperatorTransformer.scala:
##########
@@ -160,7 +178,7 @@ object FilterExecTransformerBase {
   }
 }
 
-case class ProjectExecTransformer private (projectList: Seq[NamedExpression], 
child: SparkPlan)
+abstract class ProjectExecTransformerBase(val list: Seq[NamedExpression], val 
input: SparkPlan)

Review Comment:
   @zhztheplayer here is a change from case class to abstract class, any 
concerns about this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to