zhouyuan commented on code in PR #7479:
URL: https://github.com/apache/incubator-gluten/pull/7479#discussion_r1797542944
##########
cpp/core/compute/Runtime.cc:
##########
@@ -68,4 +68,11 @@ void Runtime::release(Runtime* runtime) {
delete runtime;
}
+std::optional<std::string>* Runtime::localWriteFilesTempPath() {
+ // This is thread-local to conform to Java side ColumnarWriteFilesExec's
design.
+ // FIXME: Pass the path through relevant member functions.
+ static thread_local std::optional<std::string> path;
Review Comment:
do we really need `thread_local` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
