This is an automated email from the ASF dual-hosted git repository.
philo pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git
The following commit(s) were added to refs/heads/main by this push:
new 21ff0fe33a [GLUTEN-7495][BUILD] Fix macOS does not support
version-script (#7497)
21ff0fe33a is described below
commit 21ff0fe33ab000f56655b3ed4a4b87c3255210a5
Author: Mingliang Zhu <[email protected]>
AuthorDate: Sat Oct 12 19:34:27 2024 +0800
[GLUTEN-7495][BUILD] Fix macOS does not support version-script (#7497)
---
cpp/core/CMakeLists.txt | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/cpp/core/CMakeLists.txt b/cpp/core/CMakeLists.txt
index 70ef21d530..1dd31c1a1c 100644
--- a/cpp/core/CMakeLists.txt
+++ b/cpp/core/CMakeLists.txt
@@ -216,8 +216,10 @@ add_dependencies(gluten jni_proto)
# Hide symbols of some static dependencies. Otherwise, if such dependencies are
# already statically linked to libvelox.so, a runtime error will be reported:
# xxx is being linked both statically and dynamically.
-target_link_options(
- gluten PRIVATE -Wl,--version-script=${CMAKE_CURRENT_SOURCE_DIR}/symbols.map)
+if(NOT CMAKE_SYSTEM_NAME MATCHES "Darwin")
+ target_link_options(
+ gluten PRIVATE
-Wl,--version-script=${CMAKE_CURRENT_SOURCE_DIR}/symbols.map)
+endif()
if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS 9.0)
execute_process(
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
