This is an automated email from the ASF dual-hosted git repository.
philo pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git
The following commit(s) were added to refs/heads/main by this push:
new 6ede705391 [GLUTEN-7539][VL] Remove some unnecessary Velox code
changes from modify_velox.patch (#7540)
6ede705391 is described below
commit 6ede705391056f8bc62fc6cb6d112710b81e2240
Author: PHILO-HE <[email protected]>
AuthorDate: Wed Oct 16 09:14:45 2024 +0800
[GLUTEN-7539][VL] Remove some unnecessary Velox code changes from
modify_velox.patch (#7540)
---
ep/build-velox/src/modify_velox.patch | 29 +----------------------------
1 file changed, 1 insertion(+), 28 deletions(-)
diff --git a/ep/build-velox/src/modify_velox.patch
b/ep/build-velox/src/modify_velox.patch
index 7221aa031f..5c1aab2489 100644
--- a/ep/build-velox/src/modify_velox.patch
+++ b/ep/build-velox/src/modify_velox.patch
@@ -103,18 +103,6 @@ index 7f7cbc92f..52adb1250 100644
if(NOT TARGET gflags::gflags)
# This is a bit convoluted, but we want to be able to use gflags::gflags as
a
# target even when velox is built as a subproject which uses
-diff --git a/velox/common/process/tests/CMakeLists.txt
b/velox/common/process/tests/CMakeLists.txt
-index 23ef279c2..7e4c2f2b2 100644
---- a/velox/common/process/tests/CMakeLists.txt
-+++ b/velox/common/process/tests/CMakeLists.txt
-@@ -24,4 +24,6 @@ target_link_libraries(
- fmt::fmt
- velox_time
- GTest::gtest
-- GTest::gtest_main)
-+ GTest::gtest_main
-+ glog::glog
-+ gflags::gflags)
diff --git
a/velox/connectors/hive/storage_adapters/abfs/RegisterAbfsFileSystem.cpp
b/velox/connectors/hive/storage_adapters/abfs/RegisterAbfsFileSystem.cpp
index a8b0df52a..254c56b70 100644
--- a/velox/connectors/hive/storage_adapters/abfs/RegisterAbfsFileSystem.cpp
@@ -139,19 +127,4 @@ index 10ee508ba..027a58ecc 100644
+ hadoopHomeDirectory.remove_filename().remove_filename();
setupEnvironment(hadoopHomeDirectory.string());
}
-
-diff --git a/velox/dwio/parquet/writer/arrow/tests/CMakeLists.txt
b/velox/dwio/parquet/writer/arrow/tests/CMakeLists.txt
-index 0cda25430..b15565796 100644
---- a/velox/dwio/parquet/writer/arrow/tests/CMakeLists.txt
-+++ b/velox/dwio/parquet/writer/arrow/tests/CMakeLists.txt
-@@ -38,7 +38,9 @@ target_link_libraries(
- GTest::gtest
- GTest::gtest_main
- arrow
-- arrow_testing)
-+ arrow_testing
-+ glog::glog
-+ gflags::gflags)
-
- add_library(
- velox_dwio_arrow_parquet_writer_test_lib
+
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
