clay4megtr commented on PR #7553: URL: https://github.com/apache/incubator-gluten/pull/7553#issuecomment-2415729834
> Thanks. Can we pre-allocate a buffer of size `options_.pushBufferMaxSize`, and make rssBufferOs reuse the memory each time? That's a better solution, I'll update later. btw, I have another question, is it possible that `sortTime` which defined [here](https://github.com/apache/incubator-gluten/blob/66bb774f33e7419996bd052ae2ba9cbafcf9a489/gluten-celeborn/velox/src/main/scala/org/apache/spark/shuffle/VeloxCelebornColumnarShuffleWriter.scala#L99) include cost time of other spill type? because the trigger root is `nativeShuffleWriter.write(...)` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
