zhouyuan commented on PR #7578: URL: https://github.com/apache/incubator-gluten/pull/7578#issuecomment-2420938203
> > @PHILO-HE should we upgrade the docker image in a separate PR, and tag it with gcc-11? otherwise it may break some old tests > > @zhouyuan, maybe, we can directly install upgraded GCC in this pr with the old docker images used. After docker images are updated with new gcc installed, we can remove unnecessary installation from yml. > > Regarding updating docker image, I think we should keep both gcc-9/11 installed. Then, use required gcc version by sourcing corresponding SCL devtoolset. This is for considering branch-1.2 GHA workflow, where gcc-9 is still used. Yes, that's the issue. We will need to modify the branch-1.2 also if image is updated with same name -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
