zhztheplayer commented on code in PR #7606:
URL: https://github.com/apache/incubator-gluten/pull/7606#discussion_r1808023968
##########
gluten-core/src/main/scala/org/apache/gluten/extension/columnar/enumerated/EnumeratedApplier.scala:
##########
@@ -56,10 +56,8 @@ class EnumeratedApplier(
finalPlan
}
- private def apply0(rules: Seq[Rule[SparkPlan]], plan: SparkPlan): SparkPlan
= {
- val executor = new ColumnarRuleApplier.Executor("ras", rules)
- executor.execute(plan)
- }
+ private def apply0(rules: Seq[Rule[SparkPlan]], plan: SparkPlan): SparkPlan =
+ new ColumnarRuleApplier.ColumnarRuleExecutor("ras", rules).execute(plan)
Review Comment:
`ColumnarRuleApplier.ColumnarRuleExecutor` sounds a little bit too long.
Let's move `ColumnarRuleExecutor` to an individual file, i.e.,
`ColumnarRuleExecutor.scala`? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
