ivoson commented on code in PR #7167:
URL: https://github.com/apache/incubator-gluten/pull/7167#discussion_r1808046783
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxMetricsApi.scala:
##########
@@ -38,13 +39,29 @@ class VeloxMetricsApi extends MetricsApi with Logging {
}
override def genInputIteratorTransformerMetrics(
+ child: SparkPlan,
sparkContext: SparkContext): Map[String, SQLMetric] = {
+ def metricsPlan(plan: SparkPlan): SparkPlan = {
+ plan match {
+ case ColumnarInputAdapter(child) => metricsPlan(child)
+ case q: QueryStageExec => metricsPlan(q.plan)
+ case _ => plan
+ }
+ }
Review Comment:
> I meant we can still keep the current code path in main stream code for
the case of `child != broadcast exchange`. When `child == broadcast exchange`,
we can grab the metrics from `child.metrics` to avoid duplicating the numbers.
Does that sound feasible to you?
Sure, I am fine with it. Will update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
