zhztheplayer commented on code in PR #7620:
URL: https://github.com/apache/incubator-gluten/pull/7620#discussion_r1809758639
##########
gluten-substrait/src/main/scala/org/apache/gluten/execution/BasicPhysicalOperatorTransformer.scala:
##########
@@ -210,14 +210,6 @@ abstract class ProjectExecTransformerBase(val list:
Seq[NamedExpression], val in
override def doTransform(context: SubstraitContext): TransformContext = {
val childCtx = child.asInstanceOf[TransformSupport].transform(context)
val operatorId = context.nextOperatorId(this.nodeName)
- if ((list == null || list.isEmpty) && childCtx != null) {
- // The computing for this project is not needed.
- // the child may be an input adapter and childCtx is null. In this case
we want to
- // make a read node with non-empty base_schema.
- context.registerEmptyRelToOperator(operatorId)
- return childCtx
- }
Review Comment:
`context.registerEmptyRelToOperator(operatorId)` looks to be suitable only
when the operator simply outputs all the inputs it receives. Which is not the
case here for `list.isEmpty`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
