Yohahaha commented on code in PR #7476:
URL: https://github.com/apache/incubator-gluten/pull/7476#discussion_r1814130997
##########
shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala:
##########
@@ -2125,4 +2127,12 @@ object GlutenConfig {
"Otherwise, throw an exception.")
.booleanConf
.createWithDefault(true)
+
+ val CAST_FROM_VARCHAR_ADD_TRIM_NODE =
+ buildConf("spark.gluten.velox.castFromVarcharAddTrimNode")
+ .internal()
+ .doc("If true, will add a trim node which has the same sementic as
vanilla Spark." +
+ "Otherwise, do nothing.")
+ .booleanConf
+ .createWithDefault(true)
Review Comment:
I think we can set default value to false, because all GHA has passed and
performance boost can not be ignored. If incorrect result issue occurs, we can
fix it or make this config more fine-grained.
Just like scan parquet complex types, we remove force fallback config after
all UT passed.
@PHILO-HE @jackylee-ch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
