jinchengchenghh commented on PR #7592: URL: https://github.com/apache/incubator-gluten/pull/7592#issuecomment-2436898609
> Most of the comments are minors. Thanks. > > BTW I see there is a `return` at line 120 here: > > https://github.com/apache/incubator-gluten/blob/0f82fd0b9d0189534b8fa5b006e56d0e964114e2/backends-velox/src/main/scala/org/apache/gluten/execution/ColumnarPartialProjectExec.scala#L117-L127 > > Would you like to reason about it a bit? I think we should avoid this kind of return statements in lambda. Let's use `Expression.exists` for fast-failing if needed. Thanks for catching it, I change to `forall` to end up fast. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
