marin-ma commented on PR #7666:
URL: 
https://github.com/apache/incubator-gluten/pull/7666#issuecomment-2436916657

   For CH UTs, queries in 
`backends-clickhouse/src/test/resources/queries/tpch-queries-ch` and 
`gluten-core/src/test/resources/tpch-queries` are  identical except for the 
former one has join hints. E.g.
   
   ```
   diff 
./backends-clickhouse/src/test/resources/queries/tpch-queries-ch/q03.sql 
./gluten-core/src/test/resources/tpch-queries/q03.sql
   1c1
   < SELECT /*+ SHUFFLE_MERGE(lineitem) */
   ---
   > SELECT
   ```
   
   Some queries in `gluten-core/src/test/resources/tpch-queries` and 
`tools/gluten-it/common/src/main/resources/tpch-queries` are different. 
   
   For CH UTs, replace the reference to 
`gluten-core/src/test/resources/tpch-queries` with 
`tools/gluten-it/common/src/main/resources/tpch-queries` as long as the UT can 
pass. Otherwise replace with 
`backends-clickhouse/src/test/resources/queries/tpch-queries-ch`
   
   @loneylee @taiyang-li @shuai-xu Please help to review if you have any 
comments.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to