zhztheplayer commented on PR #7686: URL: https://github.com/apache/incubator-gluten/pull/7686#issuecomment-2443059916
> > Is it possible for you to share some test results about this change? Thanks! > > I ran it in our grayscale adhoc query environment yesterday, and executorCpuTime overall reduced by 10%. @zhztheplayer Sounds great. BTW, based on my impression RoughCostModel has been used by a few of users. If you want to continue working on the new costers, would you consider creating a new one like `RoughCostModel2`, with alias `rough2`, probably? So we don't break the current usages of `rough` model by accident. Once it gets mature rough, we can move the logics to a more standardized cost model then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
