zhztheplayer commented on PR #7691: URL: https://github.com/apache/incubator-gluten/pull/7691#issuecomment-2443051295
@beliefer Aside of the constructor changes for `GlutenConfig`, I think 2 parts of code cleanups can be split and merged first. Would you want to split out the following parts from the PR? 1. Rule constructor simplifications: E.g., `RewriteDateTimestampComparisonRule(session: SparkSession, conf: SQLConf)` to `RewriteDateTimestampComparisonRule(conf: SQLConf)` or `RewriteDateTimestampComparisonRule(session: SparkSession)` 2. Naming improvements: E.g., `columnarConf` to `glutenConf` Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
