This is an automated email from the ASF dual-hosted git repository.
hongze pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git
The following commit(s) were added to refs/heads/main by this push:
new c35d97ed46 [GLUTEN-7143][VL] RAS: Fix test case "test ignore row to
columnar" when RAS=ON (#7725)
c35d97ed46 is described below
commit c35d97ed46a1ecfff11707c44249a425d5a3cf20
Author: Hongze Zhang <[email protected]>
AuthorDate: Wed Oct 30 12:52:13 2024 +0800
[GLUTEN-7143][VL] RAS: Fix test case "test ignore row to columnar" when
RAS=ON (#7725)
---
.../src/test/scala/org/apache/gluten/execution/FallbackSuite.scala | 1 +
.../scala/org/apache/spark/sql/execution/ColumnarWriteFilesExec.scala | 2 +-
shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala | 2 +-
3 files changed, 3 insertions(+), 2 deletions(-)
diff --git
a/backends-velox/src/test/scala/org/apache/gluten/execution/FallbackSuite.scala
b/backends-velox/src/test/scala/org/apache/gluten/execution/FallbackSuite.scala
index 597009ed71..d8b0ee8981 100644
---
a/backends-velox/src/test/scala/org/apache/gluten/execution/FallbackSuite.scala
+++
b/backends-velox/src/test/scala/org/apache/gluten/execution/FallbackSuite.scala
@@ -233,6 +233,7 @@ class FallbackSuite extends VeloxWholeStageTransformerSuite
with AdaptiveSparkPl
Seq("true", "false").foreach {
ignoreRowToColumnar =>
withSQLConf(
+ GlutenConfig.RAS_ENABLED.key -> "false",
GlutenConfig.COLUMNAR_FALLBACK_IGNORE_ROW_TO_COLUMNAR.key ->
ignoreRowToColumnar,
GlutenConfig.EXPRESSION_BLACK_LIST.key -> "collect_set",
GlutenConfig.COLUMNAR_WHOLESTAGE_FALLBACK_THRESHOLD.key -> "1"
diff --git
a/gluten-substrait/src/main/scala/org/apache/spark/sql/execution/ColumnarWriteFilesExec.scala
b/gluten-substrait/src/main/scala/org/apache/spark/sql/execution/ColumnarWriteFilesExec.scala
index 0f2139c3b6..fcd82d8c19 100644
---
a/gluten-substrait/src/main/scala/org/apache/spark/sql/execution/ColumnarWriteFilesExec.scala
+++
b/gluten-substrait/src/main/scala/org/apache/spark/sql/execution/ColumnarWriteFilesExec.scala
@@ -155,7 +155,7 @@ object ColumnarWriteFilesExec {
private val NoopTag =
TreeNodeTag[Boolean]("org.apache.spark.sql.execution.ColumnarWriteFilesExec.NoopTag")
- // Decides whether a plan not is on the dummy `WriteFilesExec + NoopLeaf`
path.
+ // Decides whether a plan node is on the dummy `WriteFilesExec + NoopLeaf`
path.
object OnNoopLeafPath {
def unapply(plan: SparkPlan): Option[NoopLeaf] = {
val leafs = traverseDown(plan)
diff --git a/shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala
b/shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala
index 49ed28d1dd..a28a7d26b3 100644
--- a/shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala
+++ b/shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala
@@ -476,7 +476,7 @@ class GlutenConfig(conf: SQLConf) extends Logging {
object GlutenConfig {
import SQLConf._
- var GLUTEN_ENABLED_BY_DEFAULT = true
+ val GLUTEN_ENABLED_BY_DEFAULT = true
val GLUTEN_ENABLED_KEY = "spark.gluten.enabled"
val GLUTEN_LIB_NAME = "spark.gluten.sql.columnar.libname"
val GLUTEN_LIB_PATH = "spark.gluten.sql.columnar.libpath"
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
