GitHub user zhztheplayer added a comment to the discussion: Backend-specific contents in common code spaces
> @zhztheplayer, as backends-velox / backends-clickhouse are maven modules, not > sure whether it is proper to move cpp code into them, although it should be > technically feasible to do that. Thank you for the insights. Our CPP code tightly relies on JNI so can't be individually workable without the upper layer arch or Maven code. So the code, for example `cpp/` is in away something that belongs to Velox backend's Java module from my perspective. If there is a chance we can split out the common code from `cpp/`, then it's feasible to have a common place for it. `cpp/` / `cpp-ch/` are big deals but can be easy to move. We can make the decision later anyway. The non-trivial one is UT module. I think there is no easy way to move them to backend modules without large scale refactors. GitHub link: https://github.com/apache/incubator-gluten/discussions/7735#discussioncomment-11098060 ---- This is an automatically sent email for [email protected]. To unsubscribe, please send an email to: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
