PHILO-HE commented on PR #7369: URL: https://github.com/apache/incubator-gluten/pull/7369#issuecomment-2453751849
>@PHILO-HE I have a doubt about the PR title. What does this PR have to do with LD_PRELOAD? All I see is that we're building jemalloc as a shared library in /usr/local/lib @surnaik, this pr simply allows some profiling log printed when jemalloc is used with LD_PRELOAD (set by user in runtime env.), e.g., shows memory size allocated by jemalloc. It requires linked jemalloc lib is as same as the one set by LD_PRELOAD. >Enabling this now, will add libjemalloc as a dependency of libvelox. Is this to force users to provide jemalloc using LD_PRELOAD? Not exactly. With the related build option turned on, it does not require LD_PRELOAD must be set by user. But without the use of LD_PRELOAD, turning on the option is useless since the profiling log has no helpful info (e.g., 0 byte allocated by jemalloc). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For additional commands, e-mail: commits-h...@gluten.apache.org