yikf commented on PR #7803: URL: https://github.com/apache/incubator-gluten/pull/7803#issuecomment-2456139679
> > > Be careful, the dynamic offheap feature is experimental. > > > > > > Thank you for reminding me, yea, I was just testing the feature in a test environment, and I found that this feature ignores the user-configured offheap memory. > > Noted. So the work is related to #7605? Since I didn't see the tickets linked. I didn't notice it before, but I understand the magic of https://github.com/apache/incubator-gluten/pull/5439 lies in using an on-heap memory quota to control on-heap and off-heap memory. Off-heap memory is floating and reserved for OFFHEAP_SIZING_MEMORY_FRACTION to prevent overlapping behavior when on-heap and off-heap memory are allocated simultaneously. https://github.com/apache/incubator-gluten/issues/7605 may have been intentionally designed by https://github.com/apache/incubator-gluten/pull/5439, but the current quota ignores the specified off-heap memory. This PR is used to make the quota's memory include the user-specified off-heap+on-heap. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
