PHILO-HE commented on issue #7777: URL: https://github.com/apache/incubator-gluten/issues/7777#issuecomment-2456273902
> @wForget, it's strange. I just applied the below patch to test your case on Velox side ([1.2.0 velox branch](https://github.com/oap-project/velox/commits/gluten-1.2.0)), the test passed. > > ``` > diff --git a/velox/functions/sparksql/tests/JsonFunctionsTest.cpp b/velox/functions/sparksql/tests/JsonFunctionsTest.cpp > index c0c8ecc90..f9448733a 100644 > --- a/velox/functions/sparksql/tests/JsonFunctionsTest.cpp > +++ b/velox/functions/sparksql/tests/JsonFunctionsTest.cpp > @@ -119,5 +119,9 @@ TEST_F(GetJsonObjectTest, nullResult) { > std::nullopt); > } > > +TEST_F(GetJsonObjectTest, escaped) { > + EXPECT_EQ(getJsonObject(R"({"c1":"test\ntest"})", "$.c1"), "test\ntest"); > +} > + > } // namespace > } // namespace facebook::velox::functions::sparksql::test > ``` Using regular string instead of raw string can reproduce this issue. It also occurs on the main branch. I found Presto also allows control characters, like Spark. We may have to change simdjson's code to fix this issue. But not sure whether it is acceptable. See Velox PR: https://github.com/facebookincubator/velox/pull/11433 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
