zhztheplayer commented on code in PR #7799: URL: https://github.com/apache/incubator-gluten/pull/7799#discussion_r1830636284
########## cpp/velox/memory/VeloxMemoryManager.cc: ########## @@ -22,6 +22,7 @@ #include "velox/common/memory/MallocAllocator.h" #include "velox/common/memory/MemoryPool.h" +#include "velox/common/memory/SharedArbitrator.h" #include "velox/exec/MemoryReclaimer.h" Review Comment: Why we need to include `SharedArbitrator.h`? Thought we should avoid this kind of dependency. One of the reason is, code of the shared arbitrator is usually updated frequently so we may easily find our code doesn't work after a Velox rebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
