exmy commented on PR #7867: URL: https://github.com/apache/incubator-gluten/pull/7867#issuecomment-2464341654
> @exmy, I'm not familiar with CH backend code. In velox backend, we have a validation function on native side (see below link). In its implementation, RE2 tries to compile literal regex pattern, and then some known unsupported or incompatible cases are filter out even though compiling can pass. Can this handling be a reference to you to fix your issues? > > https://github.com/apache/incubator-gluten/blob/main/cpp/velox/utils/Common.cc#L55 Thanks for advice! It's a indeed better way to validate on native side, but ch backend currently does not support it. Maybe this way wil be adopted later as well. BTW, I noticed it seems missing validate for `split` expression in https://github.com/apache/incubator-gluten/blob/main/cpp/velox/substrait/SubstraitToVeloxPlanValidator.cc#L56. The second parameter for `split` is also a regex string. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
