marin-ma commented on issue #7860: URL: https://github.com/apache/incubator-gluten/issues/7860#issuecomment-2467076248
> Another approach is in mergeSpills(), where we open the file for each partition and close it when finished. @kecookier Not sure how much performance impact this might introduce. This approach requires invoking mmap and munmap for each partition, and some partitions in a single spill file may be quite small. > We do some internal performance test, it shows ReadableFile may have some regression. How much performance regression do you see? Could you share some results? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
