zhztheplayer commented on code in PR #7885:
URL: https://github.com/apache/incubator-gluten/pull/7885#discussion_r1835912687
##########
backends-velox/src/main/scala/org/apache/spark/sql/execution/ColumnarBuildSideRelation.scala:
##########
@@ -23,51 +23,58 @@ import org.apache.gluten.runtime.Runtimes
import org.apache.gluten.sql.shims.SparkShimLoader
import org.apache.gluten.utils.ArrowAbiUtil
import org.apache.gluten.vectorized.{ColumnarBatchSerializerJniWrapper,
NativeColumnarToRowJniWrapper}
-
import org.apache.spark.sql.catalyst.InternalRow
import org.apache.spark.sql.catalyst.expressions.{Attribute,
AttributeReference, BoundReference, Expression, UnsafeProjection, UnsafeRow}
import org.apache.spark.sql.execution.joins.BuildSideRelation
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.utils.SparkArrowUtil
import org.apache.spark.sql.vectorized.ColumnarBatch
import org.apache.spark.task.TaskResources
-
import org.apache.arrow.c.ArrowSchema
+import org.apache.spark.unsafe.map.BytesToBytesMap
import scala.collection.JavaConverters.asScalaIteratorConverter
-case class ColumnarBuildSideRelation(output: Seq[Attribute], batches:
Array[Array[Byte]])
+case class ColumnarBuildSideRelation(output: Seq[Attribute], batches:
BytesToBytesMap)
Review Comment:
Any specific reason to use `BytesToBytesMap` here? Is it also suitable for
Gluten's use case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
