zml1206 commented on code in PR #7857:
URL: https://github.com/apache/incubator-gluten/pull/7857#discussion_r1835994186
##########
shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala:
##########
@@ -645,6 +643,7 @@ object GlutenConfig {
"spark.gluten.memory.dynamic.offHeap.sizing.memory.fraction"
val GLUTEN_COST_EVALUATOR_ENABLED =
"spark.gluten.sql.adaptive.costEvaluator.enabled"
+ val GLUTEN_COST_EVALUATOR_DEFAULT_VALUE = true
Review Comment:
Please update to `GLUTEN_COST_EVALUATOR_ENABLED_DEFAULT_VALUE`.
##########
shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala:
##########
@@ -2108,15 +2107,15 @@ object GlutenConfig {
.createWithDefault(true)
val COST_EVALUATOR_ENABLED =
- buildConf(GlutenConfig.GLUTEN_COST_EVALUATOR_ENABLED)
+ buildStaticConf(GlutenConfig.GLUTEN_COST_EVALUATOR_ENABLED)
.internal()
.doc(
"If true and gluten enabled, use " +
Review Comment:
Please remove `and gluten enabled`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
