ulysses-you commented on code in PR #7891:
URL: https://github.com/apache/incubator-gluten/pull/7891#discussion_r1837396702


##########
gluten-ui/src/main/scala/org/apache/spark/sql/execution/ui/GlutenSQLAppStatusListener.scala:
##########
@@ -52,7 +52,7 @@ private class GlutenSQLAppStatusListener(conf: SparkConf, 
kvstore: ElementTracki
         event.physicalPlanDescription,
         event.fallbackNodeToReason.toSeq.sortBy(_._1)
       )
-      kvstore.write(uiData)
+      kvstore.write(uiData, checkTriggers = true)

Review Comment:
   I'm afraid it would introduce overhead for driver since each aqe stage would 
post one event. I think fire the trigger at  `onSQLExecutionStart` is enough.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to