This is an automated email from the ASF dual-hosted git repository.

hongze pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git


The following commit(s) were added to refs/heads/main by this push:
     new 106fd80b64 [CORE] The fallback check for Scan should not be skipped 
when DPP is present (#7080)
106fd80b64 is described below

commit 106fd80b6441162577caa49c57a057b2ab7b27b7
Author: wang-zhun <[email protected]>
AuthorDate: Tue Nov 12 14:27:25 2024 +0800

    [CORE] The fallback check for Scan should not be skipped when DPP is 
present (#7080)
---
 .../gluten/extension/columnar/FallbackRules.scala  | 22 ++++++++--------------
 1 file changed, 8 insertions(+), 14 deletions(-)

diff --git 
a/gluten-substrait/src/main/scala/org/apache/gluten/extension/columnar/FallbackRules.scala
 
b/gluten-substrait/src/main/scala/org/apache/gluten/extension/columnar/FallbackRules.scala
index b557abe001..1268d36d32 100644
--- 
a/gluten-substrait/src/main/scala/org/apache/gluten/extension/columnar/FallbackRules.scala
+++ 
b/gluten-substrait/src/main/scala/org/apache/gluten/extension/columnar/FallbackRules.scala
@@ -272,21 +272,15 @@ case class AddFallbackTagRule() extends Rule[SparkPlan] {
     try {
       plan match {
         case plan: BatchScanExec =>
-          // If filter expressions aren't empty, we need to transform the 
inner operators.
-          if (plan.runtimeFilters.isEmpty) {
-            val transformer =
-              ScanTransformerFactory
-                .createBatchScanTransformer(plan, validation = true)
-                .asInstanceOf[BasicScanExecTransformer]
-            transformer.doValidate().tagOnFallback(plan)
-          }
+          val transformer =
+            ScanTransformerFactory
+              .createBatchScanTransformer(plan, validation = true)
+              .asInstanceOf[BasicScanExecTransformer]
+          transformer.doValidate().tagOnFallback(plan)
         case plan: FileSourceScanExec =>
-          // If filter expressions aren't empty, we need to transform the 
inner operators.
-          if (plan.partitionFilters.isEmpty) {
-            val transformer =
-              ScanTransformerFactory.createFileSourceScanTransformer(plan)
-            transformer.doValidate().tagOnFallback(plan)
-          }
+          val transformer =
+            ScanTransformerFactory.createFileSourceScanTransformer(plan)
+          transformer.doValidate().tagOnFallback(plan)
         case plan if HiveTableScanExecTransformer.isHiveTableScan(plan) =>
           HiveTableScanExecTransformer.validate(plan).tagOnFallback(plan)
         case plan: ProjectExec =>


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to