rui-mo commented on code in PR #7926:
URL: https://github.com/apache/incubator-gluten/pull/7926#discussion_r1839174968
##########
cpp/velox/operators/functions/RegistrationAllFunctions.cc:
##########
@@ -78,10 +78,10 @@ void registerFunctionOverwrite() {
void registerFunctionForConfig() {
const std::string prefix = "not_allow_precision_loss_";
Review Comment:
We might do not need this prefix. In Velox, they are registered with the
simple name w/o a suffix, like 'add' and 'add_deny_precision_loss'.
https://github.com/facebookincubator/velox/pull/10383/files#diff-4baee9f82f9c347f753972415d345941d2c2a110b608d480b090650171da096bR678-R682
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
