baibaichen opened a new pull request, #7952:
URL: https://github.com/apache/incubator-gluten/pull/7952

   ## What changes were proposed in this pull request?
   
   Issue 1
   `BuildQueryPipelineSettings` is created manually instead of calling  
B`uildQueryPipelineSettings::fromContext();` so even 
https://github.com/ClickHouse/ClickHouse/pull/71890 disable 
`'query_plan_merge_filters'`, UTs are still failed.
   
   To fix  this issue, we need set correct default parameters in CHUtil.cpp
   
   Issue 2
   If we set `query_plan_merge_filters` to true, then 
https://github.com/ClickHouse/ClickHouse/pull/71539 will try to split the left 
most AND atom to a separate DAG and hence create `FilterTransformer` for each 
**And atom**, which cause collecting metrics failed.
   
   I am not sure the benefits of setting it to true, let's keep it to false.
   
   
   ## How was this patch tested?
   
   Using Existed UTs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to