PHILO-HE commented on code in PR #7892:
URL: https://github.com/apache/incubator-gluten/pull/7892#discussion_r1843359811
##########
shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala:
##########
@@ -2170,4 +2172,11 @@ object GlutenConfig {
"Otherwise, do nothing.")
.booleanConf
.createWithDefault(false)
+
+ val HDFS_VIEWFS_ENABLED =
+ buildStaticConf("spark.gluten.storage.hdfs.viewfs.enabled")
+ .internal()
+ .doc("If enabled, gluten will convert the viewfs path to hdfs path in
scala size")
Review Comment:
typo, size -> side?
##########
shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala:
##########
@@ -2170,4 +2172,11 @@ object GlutenConfig {
"Otherwise, do nothing.")
.booleanConf
.createWithDefault(false)
+
+ val HDFS_VIEWFS_ENABLED =
+ buildStaticConf("spark.gluten.storage.hdfs.viewfs.enabled")
Review Comment:
Some of these words can be combined with no period mark, which may look
better.
-> `spark.gluten.storage.hdfsViewfs.enabled`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
