This is an automated email from the ASF dual-hosted git repository.
yuanzhou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git
The following commit(s) were added to refs/heads/main by this push:
new 9d0b9c5c81 [VL] Clean up some legacy code related to USE_AVX512
(#7956)
9d0b9c5c81 is described below
commit 9d0b9c5c81119ac0cddcc97143b79f8cab044c97
Author: PHILO-HE <[email protected]>
AuthorDate: Mon Nov 18 17:38:23 2024 +0800
[VL] Clean up some legacy code related to USE_AVX512 (#7956)
These are some legacy code inherited from Gazelle. And it's not the correct
place to do this setting for compiler if we want it for compiling all native
code.
---
cpp/CMakeLists.txt | 1 -
cpp/core/CMakeLists.txt | 14 --------------
2 files changed, 15 deletions(-)
diff --git a/cpp/CMakeLists.txt b/cpp/CMakeLists.txt
index ff934a2a8e..09d09481f2 100644
--- a/cpp/CMakeLists.txt
+++ b/cpp/CMakeLists.txt
@@ -48,7 +48,6 @@ option(BUILD_EXAMPLES "Build Examples" OFF)
option(BUILD_BENCHMARKS "Build Benchmarks" OFF)
option(ENABLE_JEMALLOC_STATS "Prints Jemalloc stats for debugging" OFF)
option(BUILD_GLOG "Build Glog from Source" OFF)
-option(USE_AVX512 "Build with AVX-512 optimizations" OFF)
option(ENABLE_HBM "Enable HBM allocator" OFF)
option(ENABLE_QAT "Enable QAT for de/compression" OFF)
option(ENABLE_IAA "Enable IAA for de/compression" OFF)
diff --git a/cpp/core/CMakeLists.txt b/cpp/core/CMakeLists.txt
index 78422e791a..94484eab82 100644
--- a/cpp/core/CMakeLists.txt
+++ b/cpp/core/CMakeLists.txt
@@ -66,20 +66,6 @@ macro(find_protobuf)
CACHE PATH "Protobuf include path")
endmacro()
-if(USE_AVX512)
- # Only enable additional instruction sets if they are supported
- message(STATUS "System processor: ${CMAKE_SYSTEM_PROCESSOR}")
- if(CMAKE_SYSTEM_PROCESSOR MATCHES "(x86)|(X86)|(amd64)|(AMD64)")
- set(AVX512_FLAG "-march=skylake-avx512")
- check_cxx_compiler_flag(${AVX512_FLAG} CXX_SUPPORTS_AVX512)
- if(NOT CXX_SUPPORTS_AVX512)
- message(FATAL_ERROR "AVX512 required but compiler doesn't support it.")
- endif()
- set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${AVX512_FLAG}")
- add_definitions(-DCOLUMNAR_PLUGIN_USE_AVX512)
- endif()
-endif()
-
# Set up Proto
set(PROTO_OUTPUT_DIR "${CMAKE_CURRENT_BINARY_DIR}/proto")
file(MAKE_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/proto)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
