zhouyuan commented on PR #7973:
URL:
https://github.com/apache/incubator-gluten/pull/7973#issuecomment-2484674430
@weiting-chen it seems there are some other commits required:
```
/__w/incubator-gluten/incubator-gluten/ep/build-velox/build/velox_ep/velox/exec/RowContainer.h:
In instantiation of 'static void
facebook::velox::exec::RowContainer::extractValuesWithNulls(const char* const*,
folly::Range<const int*>, int32_t, int32_t, int32_t, uint8_t, int32_t,
facebook::velox::FlatVector<T>*) [with bool useRowNumbers = false; T =
facebook::velox::StringView; int32_t = int; uint8_t = unsigned char]':
/__w/incubator-gluten/incubator-gluten/ep/build-velox/build/velox_ep/velox/exec/RowContainer.h:854:47:
required from 'static void
facebook::velox::exec::RowContainer::extractColumnTypedInternal(const char*
const*, folly::Range<const int*>, int32_t, facebook::velox::exec::RowColumn,
int32_t, const VectorPtr&) [with bool useRowNumbers = false;
facebook::velox::TypeKind Kind = facebook::velox::TypeKind::VARCHAR; int32_t =
int; facebook::velox::VectorPtr = std::shared_ptr<facebook::velox::BaseVector>]'
/__w/incubator-gluten/incubator-gluten/ep/build-velox/build/velox_ep/velox/exec/RowContainer.h:823:46:
required from 'static void
facebook::velox::exec::RowContainer::extractColumnTyped(const char* const*,
folly::Range<const int*>, int32_t, facebook::velox::exec::RowColumn, int32_t,
const VectorPtr&) [with facebook::velox::TypeKind Kind =
facebook::velox::TypeKind::VARCHAR; int32_t = int; facebook::velox::VectorPtr =
std::shared_ptr<facebook::velox::BaseVector>]'
/__w/incubator-gluten/incubator-gluten/ep/build-velox/build/velox_ep/velox/exec/RowContainer.h:1424:3:
required from here
/__w/incubator-gluten/incubator-gluten/ep/build-velox/build/velox_ep/velox/exec/RowContainer.h:932:10:
warning: variable 'values' set but not used [-Wunused-but-set-variable]
932 | auto values = valuesBuffer->asMutableRange<T>();
| ^~~~~~
[ 60%] Building CXX object
velox/CMakeFiles/velox.dir/compute/iceberg/IcebergPlanConverter.cc.o
/__w/incubator-gluten/incubator-gluten/cpp/velox/compute/WholeStageResultIterator.cc:
In member function 'void gluten::WholeStageResultIterator::collectMetrics()':
/__w/incubator-gluten/incubator-gluten/cpp/velox/compute/WholeStageResultIterator.cc:321:28:
error: 'kShowTaskMetricsWhenFinished' was not declared in this scope
321 | veloxCfg_->get<bool>(kShowTaskMetricsWhenFinished,
kShowTaskMetricsWhenFinishedDefault)) {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/__w/incubator-gluten/incubator-gluten/cpp/velox/compute/WholeStageResultIterator.cc:321:58:
error: 'kShowTaskMetricsWhenFinishedDefault' was not declared in this scope
321 | veloxCfg_->get<bool>(kShowTaskMetricsWhenFinished,
kShowTaskMetricsWhenFinishedDefault)) {
|
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
