zhztheplayer commented on code in PR #7967:
URL: https://github.com/apache/incubator-gluten/pull/7967#discussion_r1847652655
##########
gluten-iceberg/src/test/scala/org/apache/gluten/execution/IcebergSuite.scala:
##########
@@ -21,9 +21,10 @@ import org.apache.gluten.GlutenConfig
import org.apache.spark.SparkConf
import org.apache.spark.sql.Row
-class VeloxIcebergSuite extends WholeStageTransformerSuite {
-
+abstract class IcebergSuite extends WholeStageTransformerSuite {
protected val rootPath: String = getClass.getResource("/").getPath
+ // FIXME: This folder is in module backends-velox so is not accessible if
profile backends-velox
+ // is not enabled during Maven build.
override protected val resourcePath: String = "/tpch-data-parquet"
override protected val fileFormat: String = "parquet"
Review Comment:
> now ch backend use the `gluten-core/src/test/resources/tpch-data` as the
tpch data.
Noted. I could open another PR to test iceberg with the data. Not sure why
different dataset is used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
