FelixYBW commented on code in PR #8045:
URL: https://github.com/apache/incubator-gluten/pull/8045#discussion_r1857742630
##########
shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala:
##########
@@ -732,7 +734,10 @@ object GlutenConfig {
COLUMNAR_MEMORY_BACKTRACE_ALLOCATION.defaultValueString),
(
GLUTEN_COLUMNAR_TO_ROW_MEM_THRESHOLD.key,
- GLUTEN_COLUMNAR_TO_ROW_MEM_THRESHOLD.defaultValue.get.toString)
+ GLUTEN_COLUMNAR_TO_ROW_MEM_THRESHOLD.defaultValue.get.toString),
Review Comment:
Let's check if spark.unsafe.sorter.spill.read.ahead.enabled is enabled or
not. If not, close the spill read adhead buffer.
##########
shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala:
##########
@@ -1585,13 +1590,6 @@ object GlutenConfig {
.bytesConf(ByteUnit.BYTE)
.createWithDefaultString("100G")
- val COLUMNAR_VELOX_MAX_SPILL_WRITE_BUFFER_SIZE =
Review Comment:
Let's put all configurations in GlutenConfig.scala even it's not documented
in Gluten doc.
Can you add spillreadbuffersize as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
