zml1206 commented on code in PR #8062:
URL: https://github.com/apache/incubator-gluten/pull/8062#discussion_r1860201175
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxBackend.scala:
##########
@@ -399,8 +399,8 @@ object VeloxBackendSettings extends BackendSettingsApi {
case _ =>
}
windowExpression.windowFunction match {
- case _: RowNumber | _: Rank | _: CumeDist | _: DenseRank | _:
PercentRank |
- _: NthValue | _: NTile =>
+ case _: RowNumber | _: Rank | _: CumeDist | _: DenseRank | _:
PercentRank | _: NTile =>
+ case nv: NthValue if !nv.input.foldable =>
Review Comment:
This method is more friendly to changes in the number of parameters that may
exist in multi-version support. Generally, we will not change the parameter
names. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
