zhli1142015 commented on code in PR #8107:
URL: https://github.com/apache/incubator-gluten/pull/8107#discussion_r1863338612
##########
gluten-substrait/src/main/scala/org/apache/gluten/expression/UnaryExpressionTransformer.scala:
##########
@@ -43,7 +43,10 @@ case class CastTransformer(substraitExprName: String, child:
ExpressionTransform
extends UnaryExpressionTransformer {
override def doTransform(args: java.lang.Object): ExpressionNode = {
val typeNode = ConverterUtils.getTypeNode(dataType, original.nullable)
- ExpressionBuilder.makeCast(typeNode, child.doTransform(args),
original.ansiEnabled)
+ ExpressionBuilder.makeCast(
+ typeNode,
+ child.doTransform(args),
+ original.evalMode == EvalMode.ANSI)
Review Comment:
This is added in spark 3.4. I think you only need to fix the behavior in
spark 3.4 and after.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
