zhztheplayer commented on code in PR #7842:
URL: https://github.com/apache/incubator-gluten/pull/7842#discussion_r1865401622
##########
cpp/velox/substrait/SubstraitToVeloxPlanValidator.h:
##########
@@ -103,9 +106,17 @@ class SubstraitToVeloxPlanValidator {
std::vector<std::string> validateLog_;
- /// Used to get types from advanced extension and validate them.
- bool validateInputTypes(const ::substrait::extensions::AdvancedExtension&
extension, std::vector<TypePtr>& types);
+ /// Used to get types from advanced extension and validate them, then
convert to a Velox type that has arbitrary
+ /// levels of nesting.
+ bool validateInputVeloxType(const
::substrait::extensions::AdvancedExtension& extension, TypePtr& out);
Review Comment:
Changing to `parseVeloxType`. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
