acvictor commented on code in PR #8107:
URL: https://github.com/apache/incubator-gluten/pull/8107#discussion_r1866020687
##########
gluten-ut/spark35/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala:
##########
@@ -92,6 +92,16 @@ class VeloxTestSettings extends BackendTestSettings {
.exclude(
"Process Infinity, -Infinity, NaN in case insensitive manner" // +inf
not supported in folly.
)
+ enableSuite[GlutenTryCastSuite]
+ .exclude(
+ "Process Infinity, -Infinity, NaN in case insensitive manner" // +inf
not supported in folly.
+ )
+ .exclude("ANSI mode: Throw exception on casting out-of-range value to byte
type")
Review Comment:
These tests come from
https://github.com/apache/spark/blob/master/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastWithAnsiOnSuite.scala
and when the suite is run separately with
`SQLConf.get.setConf(SQLConf.ANSI_ENABLED, true)` falls back but when run as
part of `GlutenTryCastSuite` where the conf is not set does not give expected
results. (Also, the tests fail without the code changes in this PR.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
