zhztheplayer commented on code in PR #8082:
URL: https://github.com/apache/incubator-gluten/pull/8082#discussion_r1868606532
##########
gluten-substrait/src/main/scala/org/apache/gluten/execution/ScanTransformerFactory.scala:
##########
@@ -55,6 +56,11 @@ object ScanTransformerFactory {
scanExec.tableIdentifier,
scanExec.disableBucketedScan
)
+ if (!transform.doValidate().ok()) {
+ transform.copy(dataFilters =
PushDownUtil.pushFilters(scanExec.dataFilters))
+ } else {
+ transform
+ }
Review Comment:
The code in `ScanTransformerFactory` is shared between validator and offload
rules. Can we manage to move the logic to offload rules? So validation doesn't
accidently alter the plan. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
