jackylee-ch commented on code in PR #8166:
URL: https://github.com/apache/incubator-gluten/pull/8166#discussion_r1872707004


##########
.github/workflows/velox_backend.yml:
##########
@@ -513,33 +515,28 @@ jobs:
         run: |
           yum update -y && yum install -y java-1.8.0-openjdk-devel wget git
           $SETUP install_maven
-      - name: Build for Uniffle 0.9.0
+      - name: Install Uniffle ${{ matrix.uniffle }}
         run: |
           export JAVA_HOME=/usr/lib/jvm/java-1.8.0-openjdk && \
           cd /opt && \
-          git clone -b v0.9.0 https://github.com/apache/incubator-uniffle.git 
&& \
-          cd incubator-uniffle && \
-          $MVN_CMD clean install -Phadoop2.8,spark3 -DskipTests
-          cd /opt && \
-          ${WGET_CMD} 
https://archive.apache.org/dist/incubator/uniffle/0.9.0/apache-uniffle-0.9.0-incubating-bin.tar.gz
 && \
-          tar xzf apache-uniffle-0.9.0-incubating-bin.tar.gz -C /opt/ && mv 
/opt/rss-0.9.0-hadoop2.8 /opt/uniffle && \
-          ${WGET_CMD} 
https://archive.apache.org/dist/hadoop/common/hadoop-2.8.5/hadoop-2.8.5.tar.gz 
&& \
-          tar xzf hadoop-2.8.5.tar.gz -C /opt/
-          rm -rf /opt/incubator-uniffle
+          ${WGET_CMD} https://archive.apache.org/dist/incubator/uniffle/${{ 
matrix.uniffle }}/apache-uniffle-${{ matrix.uniffle }}-incubating-bin.tar.gz && 
\
+          mkdir /opt/uniffle && tar xzf apache-uniffle-${{ matrix.uniffle 
}}-incubating-bin.tar.gz -C /opt/uniffle --strip-components=1 && \
+          ${WGET_CMD} https://archive.apache.org/dist/hadoop/common/hadoop-${{ 
matrix.hadoop }}/hadoop-${{ matrix.hadoop }}.tar.gz && \
+          tar xzf hadoop-${{ matrix.hadoop }}.tar.gz -C /opt/ && \
           cd /opt/uniffle && mkdir shuffle_data && \
-          bash -c "echo -e 'XMX_SIZE=16g\nHADOOP_HOME=/opt/hadoop-2.8.5' > 
./bin/rss-env.sh" && \
+          bash -c "echo -e 'XMX_SIZE=16g\nHADOOP_HOME=/opt/hadoop-${{ 
matrix.hadoop }}' > ./bin/rss-env.sh" && \
           bash -c "echo -e 'rss.coordinator.shuffle.nodes.max 
1\nrss.rpc.server.port 19999' > ./conf/coordinator.conf" && \
           bash -c "echo -e 'rss.server.app.expired.withoutHeartbeat 
7200000\nrss.server.heartbeat.delay 3000\nrss.rpc.server.port 
19997\nrss.rpc.server.type GRPC_NETTY\nrss.jetty.http.port 
19996\nrss.server.netty.port 19995\nrss.storage.basePath 
/opt/uniffle/shuffle_data\nrss.storage.type 
MEMORY_LOCALFILE\nrss.coordinator.quorum 
localhost:19999\nrss.server.flush.thread.alive 
10\nrss.server.single.buffer.flush.threshold 64m' > ./conf/server.conf" && \
           bash ./bin/start-coordinator.sh && bash ./bin/start-shuffle-server.sh
       - name: Build for Spark ${{ matrix.spark }}
         run: |
           cd $GITHUB_WORKSPACE/ && \
           $MVN_CMD clean install -P${{ matrix.spark }} -Pbackends-velox 
-Puniffle -DskipTests
-      - name: TPC-H SF1.0 && TPC-DS SF1.0 Parquet local spark3.2 with 
uniffle-0.9.0
+      - name: TPC-H SF1.0 && TPC-DS SF1.0 Parquet local spark3.2 with uniffle

Review Comment:
   nit: we also need a `${{ matrix.uniffle }}` here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to