jackylee-ch commented on code in PR #8143:
URL: https://github.com/apache/incubator-gluten/pull/8143#discussion_r1872740532
##########
gluten-arrow/src/main/java/org/apache/gluten/init/NativeBackendInitializer.java:
##########
@@ -17,22 +17,33 @@
package org.apache.gluten.init;
import org.apache.gluten.GlutenConfig;
-import org.apache.gluten.backend.Backend;
import org.apache.gluten.utils.ConfigUtil;
import org.apache.spark.util.SparkShutdownManagerUtil;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.atomic.AtomicBoolean;
import scala.runtime.BoxedUnit;
// Initialize native backend before calling any native methods from Java side.
public final class NativeBackendInitializer {
private static final Logger LOG =
LoggerFactory.getLogger(NativeBackendInitializer.class);
- private static final AtomicBoolean initialized = new AtomicBoolean(false);
+ private static final Map<String, NativeBackendInitializer> instances = new
ConcurrentHashMap<>();
Review Comment:
Since `This doesn't tend to make Velox backend and CH backend work
together`, why we need a backend map here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
